Migrating to jasmine 2.9.1 from 2.3.4 for teaspoon

We finally decided it is probably time to try to migrate to jasmine 2.9.1 from 2.3.4

There is an error that started occurring randomly and before digging down and investigating it and and the end finding out that it is probably a result of a wrong version, we decided to try to get up to date with jasmine.

Latest jasmine version is 3.X, but 2.9.1 is a huge step from 2.3.4

We will try to migrate to 2.9.1 first. The issue is that the moment we migrated there is an error

'beforeEach' should only be used in 'describe' function

It took a couple of minutes, but what we found out is that fixtures are used in different ways.

Here is the difference and what should be done.

jasmine 2.3.4

fixture.set could be in the beforeEach and in the describe

// This works
// fixture.set is in the describe
describe("feature 1", function() {
  fixture.set(`<div id="the-div"></div>`);
  beforeEach(function() {
  })
})
// This works
// fixture.set is in the beforeEach
describe("feature 1", function() {
  beforeEach(function() {
    fixture.set(`<div id="the-div"></div>`);
  })
})

jasmine 2.9.1

fixture.set could be only in the describe and not in the before beforeEach

// This does not work as the fixture is in the beforeEach
describe("feature 1", function() {
  beforeEach(function() {
    fixture.set(`<div id="the-div"></div>`);
  })
})
// This does work
// fixture.set could be only in the describe
describe("feature 1", function() {
  fixture.set(`<div id="the-div"></div>`);  
  beforeEach(function() {
    
  })
})